#801 Add support to remove row from the GridPane #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as remove all rows.
Also added the unit tests to verify the behavior.
zshamrock
commented
Sep 15, 2018
src/main/java/tornadofx/Layouts.kt
Outdated
| */ | ||
| fun GridPane.removeRow(node: Node): Int { | ||
| if (properties.containsKey(GridPaneRowIdKey)) { | ||
| properties[GridPaneRowIdKey] = properties[GridPaneRowIdKey] as Int - 1 |
There was a problem hiding this comment.
Here the alternative implementation could be if the property value is 0, just to remove the property all together instead of subtract.
Although currently it doesn't matter, as in the current case it will result in -1, and when adding the new row the index will become 0, same as if the property were absent.
…ngle row Thinking more it feels like the better approach to remove the property rather than going to -1 value.
|
Thank you for your hard work. Let me know when you are ready to merge :) |
|
Hi, @edvin. Thank you! I am not planning to push any more changes. So if it looks good to you, feel free to proceed with the merge. |
|
Great! I will look at it in more detail ASAP and perform the merge! Thanks again :) |
|
Merged :) |
zshamrock
added a commit
to zshamrock/dynoman
that referenced
this pull request
Apr 19, 2019
As my pull request has been already merged to the TornadoFX edvin/tornadofx#802.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as remove all rows.
Currently I extend the
GridPanemanually in my own project https://github.com/zshamrock/dynoman/blob/master/src/main/kotlin/com/akazlou/dynoman/ext/Ext.kt, but would be nice to have these features as part of the TornadoFX package.Please, let me know whether the provided PR looks good or make any necessary adjustments you feel like good doing.