Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leading of sidenotes is too great #29

Closed
godbyk opened this issue Aug 7, 2015 · 5 comments
Closed

Leading of sidenotes is too great #29

godbyk opened this issue Aug 7, 2015 · 5 comments

Comments

@godbyk
Copy link
Contributor

godbyk commented Aug 7, 2015

With the smaller typeface, the line-spacing should also be less than that of the main text.

daveliepmann added a commit that referenced this issue Aug 7, 2015
@daveliepmann
Copy link
Contributor

I tweaked the line height in 6aca33a — further details or a PR would be appreciated.

@godbyk
Copy link
Contributor Author

godbyk commented Aug 7, 2015

I'd try 1.4. It's a bit tighter, but I think it still looks good.

The only nit-pick I have then is that the baselines of the sidenote and the main text aren't aligned with one another (both blocks are top-aligned). I'm afraid I don't know enough of CSS to know how to fix this, though. Perhaps there's a zero-width character that we can prepend to the sidenote that is the same size as the body text to force the baseline lower?

@jabyrd3
Copy link

jabyrd3 commented Aug 14, 2015

^ i was just about to post an issue about this. The baseline of the first line of the sidenote needs to be aligned with the baseline of the sentence it's being pulled from. Great work though, this stylesheet is awesome!

@jjsanderson
Copy link

For clarification, I appled:

.sidenote, .marginnote { line-height: 1.4; padding-top: 0.4rem; }

…which eyeballs about right to me. I checked alignment briefly using Xscope, but haven't tested exhaustively.

@daveliepmann
Copy link
Contributor

Per Edward Tufte, sidenote line-height is 1.3 as of 3aa48b4. You were right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants