Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links work in sidenotes but not in marginnotes #82

Closed
ndw opened this issue Mar 2, 2016 · 4 comments
Closed

Links work in sidenotes but not in marginnotes #82

ndw opened this issue Mar 2, 2016 · 4 comments
Labels

Comments

@ndw
Copy link

ndw commented Mar 2, 2016

It strikes me as odd that a link in a side note works fine, but the same link in a margin note doesn't work at all.

@daveliepmann
Copy link
Contributor

You're going to need to give an example of what you mean, either with code or with a screenshot or both. Does it look wrong, and if so, how? Does the link not function?

@daveliepmann
Copy link
Contributor

I cannot reproduce this underspecified issue at all. For example, I copied the anchor from sidenote 1 to the following margin note and it looks fine to me:

<label for="mn-blue-links" class="margin-toggle">&#8853;</label><input type="checkbox" id="mn-blue-links" class="margin-toggle"/> <span class="marginnote"> <a href="http://www.edwardtufte.com/tufte/books_be"><em>Beautiful Evidence</em></a> </span>

@ndw until a clear example is provided I'm tagging this invalid. If none is provided I'll close.

@ndw
Copy link
Author

ndw commented Mar 2, 2016

Ok. Thank you for your patience. I dug a little deeper into the context and discovered that a link in a marginal note doesn't work if the note appears before the <article> tag. I suppose that's not unreasonable and it's easily fixed by moving the note. In order to give the superscripts a reasonable place to go, I had to move them inside and I missed the underlying cause.

@ndw ndw closed this as completed Mar 2, 2016
@daveliepmann
Copy link
Contributor

Glad to hear a resolution :) Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants