Skip to content

Commit

Permalink
Forgot to define some new vars
Browse files Browse the repository at this point in the history
  • Loading branch information
thallada committed Jul 21, 2016
1 parent e58de55 commit db1a1f7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions analytics_dashboard/static/js/views/bar-view.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ define(['d3', 'nvd3', 'underscore', 'utils/utils', 'views/chart-view'],
formatXValue: function(xValue) {
var self = this,
trend = self.options.trends[0],
maxNumber = trend.maxNumber;

formattedXValue = ChartView.prototype.formatXTick.call(self, xValue);
maxNumber = trend.maxNumber,
formattedXValue = ChartView.prototype.formatXTick.call(self, xValue);

if (!_(maxNumber).isUndefined()) {
// e.g. 100+
Expand Down
4 changes: 2 additions & 2 deletions analytics_dashboard/static/js/views/discrete-bar-view.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ define(['d3', 'nvd3', 'underscore', 'utils/utils', 'views/bar-view'],
* Returns the original bar label or "(empty)" if no label provided.
*/
formatXValue: function(xValue) {
var self = this;
formattedXValue = BarView.prototype.formatXValue.call(self, xValue);
var self = this,
formattedXValue = BarView.prototype.formatXValue.call(self, xValue);
// Translators: (empty) is displayed as a label in a chart and indicates that no label was provided.
return _(formattedXValue).isNull() ? gettext('(empty)') : formattedXValue;
},
Expand Down

0 comments on commit db1a1f7

Please sign in to comment.