Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Update problem-builder dependency. #757

Merged
merged 1 commit into from
Nov 24, 2016

Conversation

itsjeyd
Copy link

@itsjeyd itsjeyd commented Nov 24, 2016

This PR pulls in changes from the following constituent PRs (newest first):

cf. OC-2086

Reviewers

@mtyaka
Copy link

mtyaka commented Nov 24, 2016

@itsjeyd I think we will have to skip the changes from open-craft/problem-builder#130. It includes a migration that is going to be removed (not reverted!) in open-craft/problem-builder#131.

Since I am not sure when open-craft/problem-builder#131 is getting merged, I think we should open a separate PR that only removes the migration file, and merge it to master before bumping the version number here. I'll prepare that PR now.

@itsjeyd
Copy link
Author

itsjeyd commented Nov 24, 2016

@mtyaka I see, thanks for the info. Ping me when that PR is ready, I can review it.

The build for this just failed with "Action failed: bundle install", which seems unrelated to the changes introduced here. Do you know what might be causing that failure by any chance?

@mtyaka
Copy link

mtyaka commented Nov 24, 2016

@itsjeyd PR is here: open-craft/problem-builder#133

The build error indicates that bundler was not found on the VM, which is strange. Maybe it was just a random/temporary CircleCI problem. I restarted the build to see.

@itsjeyd
Copy link
Author

itsjeyd commented Nov 24, 2016

@mtyaka I had a look, open-craft/problem-builder#133 looks good to me. Let me know if there's anything I should do to test that PR manually?

@itsjeyd itsjeyd force-pushed the itsjeyd/update-problem-builder branch from de5813f to 0074cb1 Compare November 24, 2016 10:43
@mtyaka
Copy link

mtyaka commented Nov 24, 2016

@itsjeyd The Problem Builder PR is merged.

It looks like bundler is no longer installed by default on CircleCI: https://discuss.circleci.com/t/bundle-command-not-found/3783

It looks like everybody's simply been merging broken builds since August 😕 https://github.com/edx-solutions/edx-platform/pulls?q=is%3Apr+is%3Aclosed

@itsjeyd
Copy link
Author

itsjeyd commented Nov 24, 2016

Rebased from de5813f15e41fb4633d2b2e1c852174fe74a8ff7 (to pull in changes from open-craft/problem-builder#133).

@itsjeyd
Copy link
Author

itsjeyd commented Nov 24, 2016

@mtyaka I updated the commit hash to point to updated master, and updated the PR description to include open-craft/problem-builder#133.

And thanks for looking into the bundler issue. Fixing it is out of scope here, then.

@itsjeyd
Copy link
Author

itsjeyd commented Nov 24, 2016

@mtyaka If you're happy with the updates, can I get a thumbs-up from you please? :)

Copy link

@mtyaka mtyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

If you have some extra time, it would be interesting to see if adding - gem install bunder right above the bundle install line fixes the build issues.

@bradenmacdonald
Copy link
Member

@mtyaka Yep, see #754 . Unfortunately there are several other build issues which are still unresolved. I'm not sure who's responsible for maintaining CI builds on this fork at the moment; we might also only care about the Eucalyptus builds.

@bradenmacdonald
Copy link
Member

bradenmacdonald commented Nov 24, 2016

👍

  • I don't have a dogwood solutions devstack set up at the moment, so will rely on your existing testing.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Normally we wouldn't merge a red build, but we can do so now until we've determined how the current problem will be resolved. I have asked edX.

@itsjeyd
Copy link
Author

itsjeyd commented Nov 24, 2016

Thanks @mtyaka and @bradenmacdonald, merging now.

@itsjeyd itsjeyd merged commit ef138ff into edx:master Nov 24, 2016
@bradenmacdonald bradenmacdonald deleted the itsjeyd/update-problem-builder branch November 24, 2016 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants