Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react router to v6 #120

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

Ticket

React Router Upgrade to v6.

Description

This PR upgrades React Router from v5 to v6.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Jan 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 171 lines in your changes are missing coverage. Please review.

Comparison is base (445b365) 91.59% compared to head (a74562e) 69.01%.
Report is 100 commits behind head on main.

Files Patch % Lines
...r-steps/view-results/RelatedSkillsSingleBoxSet.jsx 4.25% 45 Missing ⚠️
...lect-preferences/CareerInterestCategorizinator.jsx 2.77% 34 Missing and 1 partial ⚠️
...ps/view-results/RelatedSkillsInteractiveBoxSet.jsx 0.00% 23 Missing ⚠️
.../skills-builder-steps/SkillsBuilderProgressive.jsx 6.66% 14 Missing ⚠️
src/skills-builder/ProductTool.jsx 9.09% 10 Missing ⚠️
...lls-builder/visibility-flags-context/data/hooks.js 9.09% 8 Missing and 2 partials ⚠️
...s-builder/visibility-flags-context/data/reducer.js 0.00% 7 Missing and 1 partial ⚠️
...builder-steps/view-results/RecommendationStack.jsx 72.22% 5 Missing ⚠️
.../skills-builder-steps/view-results/ViewResults.jsx 85.29% 5 Missing ⚠️
.../skills-builder-steps/view-results/data/service.js 55.55% 2 Missing and 2 partials ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #120       +/-   ##
===========================================
- Coverage   91.59%   69.01%   -22.59%     
===========================================
  Files          30       43       +13     
  Lines         369      639      +270     
  Branches       68      152       +84     
===========================================
+ Hits          338      441      +103     
- Misses         30      188      +158     
- Partials        1       10        +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deborahgu deborahgu merged commit 77a4bc8 into main Jan 22, 2024
4 checks passed
@deborahgu deborahgu deleted the Ali-Abbas/react-router-upgrade branch January 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants