Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overide slate metadata styles #261

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nileshgulia1
Copy link
Member

If you visit: https://demo-www.eea.europa.eu/en/fdgh
The slate-metadata addon, when a part of accordion child inherits the styles applied from respective overrides file.

@github-actions
Copy link

👋 @nileshgulia1

To generate the Storybook and Docusaurus websites, write comment with:

@eea-jenkins build all

To generate only Storybook write comment with:

@eea-jenkins build storybook

To generate only Docusaurus write comment with:

@eea-jenkins build docusaurus

.publisher.metadata.mention,
.rights.metadata.mention,
.topics.text.metadata.mention {
all: unset !important;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ichim-david This reverts all styles applied on slate-metadata block, you think this should be the part of policy addon?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nileshgulia1 yes I don't like this nuke all option to have in the design package.
It seems that this is better suited for the individual site.
I can accept the padding and margin with variables but not the all unset.

.publisher.metadata.mention,
.rights.metadata.mention,
.topics.text.metadata.mention {
all: unset !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nileshgulia1 yes I don't like this nuke all option to have in the design package.
It seems that this is better suited for the individual site.
I can accept the padding and margin with variables but not the all unset.

/* override slate-metadata addon styles */
.ui.accordion .content .ui.list.metadata > .item .content,
.description {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nileshgulia1 don't leave .description rule as there are several elements that have .description class
and they would all be affected, if you meant to modify the description of accordion then add the
necessary parent classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants