Move the :*: type alias to the toplevel #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
requested changes
Jul 14, 2017
| @@ -23,6 +23,7 @@ package object sjsonnew { | |||
|
|
|||
| type LNil = LList.LNil0 | |||
| val LNil = LList.LNil0 | |||
| type :*:[A1, A2 <: LList] = LCons[A1, A2] | |||
There was a problem hiding this comment.
Weren't there a Scala compiler bug about splitting type alias and companion-looking object into different scope? scala/bug#7139
A common workaround is to move the object :*: here. See https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/data/package.scala
See SI-7139 "type alias and object with the same name cause type mismatch"
eed3si9n
approved these changes
Jul 14, 2017
|
Cool, sorry I forgot about your comments here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44