Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve tests; npm and gulp tasks #30

Merged
merged 10 commits into from
Feb 24, 2022
Merged

improve tests; npm and gulp tasks #30

merged 10 commits into from
Feb 24, 2022

Conversation

line-o
Copy link
Member

@line-o line-o commented Oct 5, 2021 •
edited
Loading

  • drop .existdb.json and put all necessary package metadata in a property app in package.json

npm packages are implicitly allowed to add their custom properties package.json but have to take care themselves not to clash with names used by npm. I have use app for other projects.

  • adopt readOptionsFromEnv to allow all npm and gulp scripts to target different existdb instances

refs #16

  • enable the custom api with middleware and token authentication by default
  • missing tests for middleware, x-constraints and custom authentication
  • allow tests on localhost to connect without a proper certificate
  • create XAR-packages in dist folder
  • prepend calls in npm scripts with dotenv where applicable. Read
    .env-files to allow setting different connection to the DB instances.
  • add npm task "develop" (running gulp default task)
  • rename npm script test:build to test:install
  • add dependency dotenv-cli
  • update dependencies @existdb/gulp-exist and @existdb/gulp-replace-tmpl

@line-o line-o force-pushed the improve-build branch 2 times, most recently from 00763a5 to 1cc0558 Compare October 5, 2021 16:22
@line-o line-o changed the title chore(build): improve npm, gulp tasks allow testing over https on localhost, improve npm, gulp tasks Oct 5, 2021
@line-o line-o requested a review from wolfgangmm October 5, 2021 16:44
@line-o line-o changed the title allow testing over https on localhost, improve npm, gulp tasks improve tests; npm and gulp tasks Oct 6, 2021
@line-o line-o mentioned this pull request Feb 9, 2022
Merged
7 tasks
@line-o
Copy link
Member Author

line-o commented Feb 11, 2022

This PR needs to be split into two because installation of the crypto-lib, which exist-jwt depends on seems to fail on docker at the moment.

@joewiz
Copy link
Member

joewiz commented Feb 13, 2022 •
edited
Loading

@line-o These sound like great enhancements - and I also appreciated the description of them that you added to eXist-db/exist-markdown#16.

Could you expand a bit on the docker failures you're seeing with crypto-lib? The links here in GitHub to the CI failures seem not to contain the logs. With more info/context, perhaps other folks could help.

@line-o line-o mentioned this pull request Feb 13, 2022
Open
@line-o
chore(build): improve npm, gulp tasks
37c7c1b 
- create XAR-packages in dist folder
- prepend calls in npm scripts with dotenv where applicable. Read
  .env-files to allow setting different connection to the DB instances.
- add npm task "develop" (running gulp default task)
- rename npm script test:build to test:install
- add dependency dotenv-cli
- update dependencies @existdb/gulp-exist and @existdb/gulp-replace-tmpl
@line-o
chore(build): improve npm, gulp tasks
31e65e0 
- create XAR-packages in dist folder
- prepend calls in npm scripts with dotenv where applicable. Read
  .env-files to allow setting different connection to the DB instances.
- add npm task "develop" (running gulp default task)
- rename npm script test:build to test:install
- add dependency dotenv-cli
- update dependencies @existdb/gulp-exist and @existdb/gulp-replace-tmpl
@line-o
feat(example): enable custom controller by default
ffcd6d2
@line-o
chore(build): improve npm, gulp tasks
78b0e56 
- create XAR-packages in dist folder
- prepend calls in npm scripts with dotenv where applicable. Read
  .env-files to allow setting different connection to the DB instances.
- add npm task "develop" (running gulp default task)
- rename npm script test:build to test:install
- add dependency dotenv-cli
- update dependencies @existdb/gulp-exist and @existdb/gulp-replace-tmpl
@line-o
fix(test): include all needed resources in testapp
4f9ce59
@line-o
fix(test): read binary from new location
eb768fa
@line-o
fix(test): login, logout in utils
2d0c064
@line-o
fix(test): require missing dependency
1a22579
@line-o
chore: update package-lock.json
2ce7b9f
@line-o
Copy link
Member Author

line-o commented Feb 18, 2022

It turned out that the public-repo instance currently installed on exist-db.org is the culprit that leads to failing installations of dependent packages. This then leads to failing tests in CI.
see eXist-db/public-repo#74 and eXist-db/node-exist#222

@line-o
Copy link
Member Author

line-o commented Feb 21, 2022

Hooray! The test application installs and tests are passing!

@line-o line-o added the enhancement New feature or request label Feb 21, 2022
@line-o line-o mentioned this pull request Feb 21, 2022
Merged
@wolfgangmm wolfgangmm merged commit 8b96270 into eeditiones:master Feb 24, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@line-o line-o mentioned this pull request Feb 24, 2022
Closed
@line-o line-o deleted the improve-build branch August 23, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangmm wolfgangmm Awaiting requested review from wolfgangmm

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@line-o @joewiz @wolfgangmm