Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning future on HipsterCollection.fetch #3

Closed
wants to merge 1 commit into from

Conversation

amiuhle
Copy link

@amiuhle amiuhle commented Jul 5, 2012

No description provided.

@eee-c
Copy link
Owner

eee-c commented Jul 30, 2012

Ah, you're right, of course. The fetch() method would be silly without returning a future. But again, this need to run through HipsterSync, which does return a future.

I believe that, if you switch to something after_call = HipsterSync.call('read', this);, then you ought to be able to achieve the same results. That is after_call.then .... and then return after_call. If you have time, please give it a try. Otherwise I'll add it in there in a bit.

Thanks again for the PRs. Sorry about the ridiculous delay.

@eee-c eee-c closed this in ed31db5 Sep 1, 2013
@amiuhle amiuhle deleted the collection-fetch-future branch September 4, 2013 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants