-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime error with node 4 #83
Comments
Thanks for creating the issue. Is it a runtime or compile time issue? Can you give some info about your setup (os, arch, etc) and about when the error occurs? |
runtime. both osx 10.11 and arm7 |
Thanks. Does it happen on a specific api call? Initial quick check of the osx code looks fine with regard to the issue you are refering. Will look into it further over the weekend. |
My program paires with the remote slave, but then this function seems to blow up, the callback is never fired.
|
Hi, i'm experiencing the same problem - downloaded the packages from npm this afternoon and hit the same issue.
During the build (on OSX) i get 2 warnings:
Not sure if these have any bearing on the problem, but thought i would include them. k. |
Thanks for the report. @jeroenhouben are you on node v4.1.2 as well? To be able to resolve this quickly I would really appreciate a stacktrace to see in exactly what line of the native code the error occurs. I'll test this myself after the weekend as I've no device to test with atm. |
yes. 4.1.2 I don't know how to get a stacktrace. This is all I see:
|
Ok thanks, I will try after the weekend... Can one of you guys try to update to the latest version of node (4.2.1) to see if this issue also occurs on that version? |
Sorry, was offline yesterday.. I just popped into the office to try v4.2.1 but i get exactly the same issue (again, no stack trace is shown - is there something i can do to get the stack trace??) I also tried v4.0.0 but same error! Trying v0.10.40, v0.11.16, and v0.12.7 I DONT get the error, but it never seems to find a channel (perhaps thats a different issue) I can use v0.12 for now to try and diagnose why i'm not getting a channel, but getting it on latest node version would be great. Thanks for your help on this @eelcocramer ! |
Thank you for the feedback. I will look into this on Monday. |
I can reproduce this. I will look into it further and keep you updated. |
I've pinned this issue down and also have a possible fix for it. But the same error occurs on other places as well but the fix is not applicable on all places so I really need to dive into these handle scopes again. The call stack for the error is below:
|
I cannot help you there, I know abs nothing about C extensions. Good luck tho! :) |
If you're up to it you can checkout the 'issue83' branch and build and test that. My simple test works fine. I'm not ready to publish it as I don't feel completely comfortable yet with the use of scopes (especially in the read function). I still need to dive into the details and understand how this is suppose to work and why it is not working in the master branch. |
👍 This fixes things for me! Thanks!! |
Thanks! If everything goes well U will push a new version to npm after the weekend. |
OK I seem to have some different problems under ARM7 still, but that could On Thu, Oct 29, 2015 at 11:49 AM, Eelco notifications@github.com wrote:
|
Published version 1.2.6 to npm. |
Hi,
This package used to compile & run fine but since node 4 its throwing this error
more info: nodejs/nan#440
The text was updated successfully, but these errors were encountered: