Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream #2

Merged
merged 21 commits into from May 15, 2020
Merged

Merge upstream #2

merged 21 commits into from May 15, 2020

Conversation

swade1987
Copy link

@swade1987 swade1987 commented May 15, 2020

rjh-yext and others added 21 commits January 15, 2020 11:19
This PR adds the ability to connect to Kafka via SASL-SCRAM 256 or 512

It adds an entry in the SASL Profile configuration called
key=mechanism
value type=string
required=no
default value=(empty)
Which accepts either values SCRAM-SHA-256, SCRAM-SHA-512

Partially addresses linkedin#526
Add SASL-SCRAM ability to Kafka connection
Currently, Burrow will attempt to create the znode used by Burrow on startup
This will cause problems if there is authentication needed when connecting
to zk.

The fix is to ignore creating zk node paths if it already exists
Ignore ZooKeeper znode Create if the path already exists
the config file and dir used by Burrow is updated for M4 and Khan
go build -o build/Burrow github.com/rjh-yext/Burrow
pulls in linkedin's branch of Burrow

Changing references of linkedin to current fork
Update module and import references
… given name. Leave that field nil to let the library select the first compatible chain from Certificates.
Add support for Kafka 2.5.0 and Go 1.14
Fixes Travis CI build of PR 598
Add Prometheus Metrics Exporter
@gavinmcnair gavinmcnair requested a review from a team May 15, 2020 15:45
Copy link

@gavinmcnair gavinmcnair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (have you checked if it builds ok)

@swade1987
Copy link
Author

Yes built the container and run it using docker-compose it works and metrics are exposed.

@swade1987 swade1987 merged commit 26d79f3 into master May 15, 2020
@swade1987 swade1987 deleted the merge-upstream branch May 15, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants