Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastboot compat #13

Merged
merged 2 commits into from Mar 16, 2017
Merged

fastboot compat #13

merged 2 commits into from Mar 16, 2017

Conversation

davidpett
Copy link
Contributor

default initialized: true when in FastBoot mode. changed willRender to didReceiveAttrs to ensure the template is rendered when in FastBoot

return Ember.getOwner(this).lookup('service:fastboot');
}),
isFastBoot: Ember.computed('fastboot', function() {
return this.get('fastboot') && this.get('fastboot.isFastBoot');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just do return this.get('fastboot.isFastBoot') (if you do this.get with a path through an undefined value, you will receive undefined back and it will not error).

@ef4 ef4 merged commit 0786faf into ef4:master Mar 16, 2017
@ef4
Copy link
Owner

ef4 commented Mar 16, 2017

Thanks @davidpett, sorry this lingered, I just caught up and found it.

@davidpett
Copy link
Contributor Author

thanks, will a new release be cut?

@kaspiCZ
Copy link

kaspiCZ commented Mar 27, 2017

This didn't work for us when we tried to update. Even tried FastBoot beta14 to be on the same page. However wrapping ember-elsewhere/addon/services/ember-elsewhere.js:27 in a isFastBoot check and running this._process() right away in FastBoot made it work. Like so:

_schedule() {
    if (this.get('fastboot.isFastBoot')) {
      this._process();
    } else {
      run.scheduleOnce('afterRender', this, this._process);
    }
  },

There's either something we borked on our end or any other ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants