mapCommentType is block for CSS files

[jamesarosen]

See ef4/broccoli-sourcemap-concat#37

[jamesarosen]

Some caveats:

1. mapCommentType is still dictated purely by this library and cannot be changed by a client. This can easily be fixed by changing the line to opts.mapCommentType || ..., but I wanted to make the smallest change that could possibly work.
2. mapCommentType is dependent upon CSS files being named *.css
3. mapCommentType is CSS-aware, but mapFile is not
4. I haven't added a test, though I'm working on it.

[stefanpenner]

mapCommentType is dependent upon CSS files being named *.css

this seems reasonable

[stefanpenner]

@rwjblue @ef4 r?

[ef4]

The upstream caller (ember-cli) always knows what kind of files it's concatenating. I would rather have it pass an appropriate option than try to autodetect based on extensions.

[jamesarosen]

The immediate upstream caller is ef4/broccoli-sourcemap-concat. Is that where you'd like a PR?

[ef4]

Yes, please. Or perhaps https://github.com/ember-cli/broccoli-concat instead. @stefanpenner, is that practical to use for everybody at this point?

[jamesarosen]

Ember-CLI 1.13 hasn't been ported to broccoli-concat yet. Broccoli-Concat also says it doesn't yet support sourcemaps.

[rwjblue]

Broccoli-Concat also says it doesn't yet support sourcemaps.

From the title of the README:

Broccoli concatenator that generates & propagates sourcemaps

This filter is designed to be fast & good enough. It can generates source maps substantially faster than you'll get via mozilla/source-map, because it's special-cased for straight line-to-line contenation.

[jamesarosen]

I could've sworn there was an open issue/PR that was basically "Broccoli doesn't do sourcemaps right yet, so ¯\_(ツ)_/¯." But I can't find it, so 🎉

[stefanpenner]

We should switch to broccoli-concat for 1.13. Although we will hopefully cutover to 2x soon

[jamesarosen]

@stefanpenner do you want me to make a go at that? Any advice?

[stefanpenner]

@jamesarosen if you want, whats preventing you from using the 2.x betas?

[jamesarosen]

@stefanpenner we're on Ember 1.13. I don't know if those are compatible.

[stefanpenner]

@stefanpenner we're on Ember 1.13. I don't know if those are compatible.
Show all checks

Yes they are compatible, the only major difference is 2.x bundles different blueprints

I would recommend upgrading, I do not believe we will back port this change.

[dfreeman]

Did an issue/PR for this ever make it to broccoli-concat? I don't see one, but wanted to make sure there aren't plans to handle this in a different layer that have come together since this thread last had activity.

[jamesarosen]

I just opened broccolijs/broccoli-concat#58