Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify everything! #49

Merged
merged 33 commits into from
Jul 15, 2019
Merged

Simplify everything! #49

merged 33 commits into from
Jul 15, 2019

Conversation

ligi
Copy link
Member

@ligi ligi commented Jul 15, 2019 •
edited
Loading

What was wrong?

#48 #35 #8

How was it fixed?

Simplifications all around and only manual confirmations for the first wave

Cute Animal Picture

image

@ligi ligi mentioned this pull request Jul 15, 2019
Closed
@pipermerriam pipermerriam mentioned this pull request Jul 15, 2019
Closed
ligi and others added 16 commits July 15, 2019 19:06
@ligi
Add waring about current state
c48b458
@davesque
Update Ethereum.is_allowed
5c60c2e
@davesque
Merge branch 'simplify' of github.com:esPass/pretix-eth-payment-plugi…
a06a9b8 
…n into simplify
@ligi
Warn users that modifying the amount is no good
20cc220
@davesque
Fix test_provider_is_allowed
e103479
@davesque
Merge branch 'simplify' of github.com:esPass/pretix-eth-payment-plugi…
2c6e04b 
…n into simplify
@davesque
Update provider tests
e7dbff3
@davesque
Remove unneeded test
fe8b5c5
@davesque
Update help text for currency selection dropdown
aeea2cc
@davesque
Remove check for txn hash for valid session
5a51840
@davesque
Update payment confirmation view
ef2ffff
@ligi
Make DAI with Web3Connect work
e28e6e8
@davesque
Remove transaction code from execute_payment
502b583
@davesque
Merge branch 'simplify' of github.com:esPass/pretix-eth-payment-plugi…
726f621 
…n into simplify
@davesque
Remove unneeded method override and template
92fdd49
@davesque
Fix tests
bb5ce45
@davesque davesque changed the title WIP - Simplify Simplify everything! Jul 15, 2019
@davesque davesque merged commit 0a05e91 into master Jul 15, 2019
@ligi ligi mentioned this pull request Jul 15, 2019
Open
@ligi ligi mentioned this pull request Aug 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrouid pedrouid pedrouid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ligi @pedrouid @davesque