Allow name in attach when only passing effect

effector · Mar 10, 2024 · e3323e3 · e3323e3
1 parent b7770df
commit e3323e3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/effector/index.d.ts b/packages/effector/index.d.ts
@@ -2742,6 +2742,7 @@ export function attach<
   FX extends Effect<any, any, any>,
 >(config: {
   effect: FX
+  name?: string
 }): Effect<EffectParams<FX>, EffectResult<FX>, EffectError<FX>>
 /**
  * Method for creating state-dependent effect and transforming effect payload

diff --git a/src/types/__tests__/effector/attach.test.ts b/src/types/__tests__/effector/attach.test.ts
@@ -156,6 +156,16 @@ test('without source and mapParams (should pass)', () => {
   `)
 })
 
+test('effect with explicit name (should pass)', () => {
+  const effect: Effect<void, void, Error> = createEffect()
+  const fx: Effect<void, void, Error> = attach({effect, name: 'fx'})
+  expect(typecheck).toMatchInlineSnapshot(`
+    "
+    no errors
+    "
+  `)
+})
+
 describe('unknown params type', () => {
   test('unknown params type [with source] (?)', () => {
     const source = createStore(0)