Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of values during fork brakes serialization ignore #609

Closed
igorkamyshev opened this issue Jan 26, 2022 · 3 comments · Fixed by #903
Closed

Replacement of values during fork brakes serialization ignore #609

igorkamyshev opened this issue Jan 26, 2022 · 3 comments · Fixed by #903
Labels
bug Something isn't working fork api good first issue Good for newcomers

Comments

@igorkamyshev
Copy link
Member

igorkamyshev commented Jan 26, 2022

What is the current behavior:

  1. Create non-serializable store (with serialize: 'ignore')
  2. Change its value during fork
  3. Serialize fork values
  4. Value of store will be serialized

Please provide the steps to reproduce and if possible a minimal demo of the problem via https://share.effector.dev, https://codesandbox.io or similar

https://share.effector.dev/CNYd8jSq

What is the expected behavior:

  1. Create non-serializable store (with serialize: 'ignore')
  2. Change its value during fork
  3. Serialize fork values
  4. Value of store won't be serialized

Which versions of effector packages, and which browser and OS are affected by this issue? Did this work in previous versions of effector?:

master

@igorkamyshev igorkamyshev added bug Something isn't working needs triage labels Jan 26, 2022
@sergeysova sergeysova added the good first issue Good for newcomers label Aug 3, 2022
@sergeysova
Copy link
Collaborator

Dear newcomers, research can be started from this place https://github.com/effector/effector/blob/master/src/effector/fork/fork.ts

@kireevmp
Copy link
Contributor

@igorkamyshev this looks fixed by #903. Can you check if the issue is still relevant?

@igorkamyshev
Copy link
Member Author

Yep, it's fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fork api good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants