add filter and filterMap types to Effect #376

sergeysova · 2020-08-13T16:08:40Z

const fx = createEffect().use(() => null)

const d = fx.filter({
  fn(a) {
    return a > 0
  },
})

d.watch(console.log)

fx(5)
fx(0)
fx(1)

https://share.effector.dev/G34PZ7qF

doasync · 2020-08-13T16:15:20Z

packages/effector/index.d.ts

@@ -139,6 +139,8 @@ export interface Effect<Params, Done, Fail = Error> extends Unit<Params> {
  pending: Store<boolean>
  inFlight: Store<number>
  watch(watcher: (payload: Params) => any): Subscription
+  filter(config: {fn(payload: Params): boolean}): Event<Params>
+  filterMap<T>(fn: (payload: Params) => T | undefined): Event<T>


Is there a reason why you have skipped the first overload?

It is forgotten.

zerobias · 2020-08-13T21:39:52Z

👍

add filter and filterMap types to Effect

f7235e6

sergeysova requested a review from zerobias August 13, 2020 16:08

doasync reviewed Aug 13, 2020

View reviewed changes

zerobias merged commit 7b35a71 into master Aug 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add filter and filterMap types to Effect #376

add filter and filterMap types to Effect #376

sergeysova commented Aug 13, 2020 •

edited

Loading

doasync Aug 13, 2020

doasync Aug 13, 2020

sergeysova Aug 14, 2020

zerobias commented Aug 13, 2020

add filter and filterMap types to Effect #376

add filter and filterMap types to Effect #376

Conversation

sergeysova commented Aug 13, 2020 • edited Loading

doasync Aug 13, 2020

Choose a reason for hiding this comment

doasync Aug 13, 2020

Choose a reason for hiding this comment

sergeysova Aug 14, 2020

Choose a reason for hiding this comment

zerobias commented Aug 13, 2020

sergeysova commented Aug 13, 2020 •

edited

Loading