Merged
Conversation
7ff07f2 to
dac78a2
Compare
zerobias
reviewed
Oct 9, 2020
|
|
||
| export interface Event<Payload> extends Unit<Payload> { | ||
| (payload: Payload): Payload | ||
| (this: Payload extends void ? void : `Error: Expected 1 argument, but got 0`): void |
Member
Author
Member
There was a problem hiding this comment.
What is `Error: Expected 1 argument, but got 0`?
Member
Author
There was a problem hiding this comment.
It's just a text to show in the error message
Member
Author
There was a problem hiding this comment.
According to tests, it will be shown only if Event expects an argument, but no parameters given.
doasync
commented
Oct 9, 2020
| @@ -355,9 +355,6 @@ describe('#filterMap', () => { | |||
| " | |||
| --typescript-- | |||
| Type 'Event<number>' is not assignable to type 'Event<number | void>'. | |||
Member
Author
There was a problem hiding this comment.
It is important to put "this" overload after the first one to keep this kind of messages right.
dac78a2 to
80ee403
Compare
Member
Author
|
I've updated the snapshot, tests pass |
Member
|
Interesting solution, okay, lets try it. Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Use case:
This PR adds void function interop:
The only weak spot is the text of the message:
All tests pass!