/ effector Public
Add type tests for prepend, improve prepend type #415
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
prependmethod infers payload type from the function argument if it exists... and if there is no argument the resulting payload type will be of type
unknown. This is a bug because a user cannot call
Event<unknown>without params - it waits for 1 argument with type
To bypass the type error, a user needs to specify
But we can fix this by adding a default type to prepend's
As the result, TypeScript will show an error when you directly call
Event<void>with an argument, which is good too:
Now it can be seen that the addition of the default value improves typing in both cases.
P.S. I also added type tests for
.prependand the described cases.