Fix/useStore #431
Merged
Fix/useStore #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy request for effector-docs pending review. 🔨 Explore the source changes: b404282 |
zarabotaet
force-pushed
the
fix/useStore
branch
from
3568230
to
8291dac
Compare
|
Because useState is a wrapper around useReducer we can directly take useReducer. |
zerobias
requested changes
Dec 30, 2020
|
|
||
| const Display = () => { | ||
| const store = useStore($store) | ||
| fn() |
There was a problem hiding this comment.
There should be a proof that issues does exists at all: your example reveal that current implementation works as expected
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two different workarounds in two commits