New sample types - #445
Merged
Merged
Conversation
|
Deploy request for effector-docs pending review. Review with commit b644373 |
zerobias
reviewed
Jan 24, 2021
| expect(typecheck).toMatchInlineSnapshot(` | ||
| " | ||
| no errors | ||
| Expected 2 type arguments, but got 1. |
Member
Author
There was a problem hiding this comment.
I believe I can solve it)
doasync
changed the title
sample types (for generated type tests)sample types (proof of concept)
doasync
force-pushed
the
new-sample-types
branch
from
January 24, 2021 16:18
6ed55f4 to
007fbd4
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 25, 2021 12:07
92b1f0b to
7d4be3b
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 25, 2021 13:01
02ffc1e to
c947ca3
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 26, 2021 11:44
c947ca3 to
7e1dd7f
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 26, 2021 12:05
c7cdc1e to
e1cc0df
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 26, 2021 12:17
e1cc0df to
314b500
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 26, 2021 18:07
db6cb34 to
ed4b54c
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 26, 2021 18:18
ed4b54c to
5180d46
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 26, 2021 18:58
5180d46 to
5299130
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 26, 2021 22:35
5299130 to
8008274
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 26, 2021 23:49
408c884 to
6dacf10
Compare
doasync
force-pushed
the
new-sample-types
branch
from
January 27, 2021 00:59
a9409b3 to
eab89c7
Compare
zerobias
marked this pull request as ready for review
January 27, 2021 01:39
Member
|
Fantastic work! This going to be a huge improvement in developer experience 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.