Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow domain to be used in attach without parent effect #895

Conversation

kireevmp
Copy link
Contributor

Closes #829
Related #763

@stackblitz
Copy link

stackblitz bot commented May 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented May 11, 2023

‼️ Deploy request for effector-docs rejected.

Name Link
🔨 Latest commit b1b13a9

Copy link
Collaborator

@sergeysova sergeysova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zerobias zerobias mentioned this pull request May 15, 2023
75 tasks
@zerobias zerobias added this to the effector Spacewatch 23.0.0 milestone Jun 6, 2023
sergeysova added a commit that referenced this pull request Jun 10, 2023
@sergeysova sergeysova changed the base branch from master to release/v23 July 6, 2023 06:34
@YanLobat YanLobat merged commit 8ed9a5e into effector:release/v23 Aug 18, 2023
1 check passed
@kireevmp kireevmp deleted the feat/domain-in-attach-without-parent-effect branch November 28, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to pass domain to attach without parent effect
4 participants