Introduce UnitTargetable, EventCallable and StoreWritable by AlexandrHoroshih · Pull Request #966 · effector/effector

AlexandrHoroshih · 2023-09-10T15:01:37Z

Conventions

Please check your messages against the guidelines if not, perform interactive rebase
Link an issue your pull request closes or relates

bolt-new-by-stackblitz · 2023-09-10T15:01:39Z

Run & review this pull request in StackBlitz Codeflow.

src/types/__tests__/effector/generated/sampleFilter.test.ts

src/types/__tests__/effector/guard.test.ts

src/types/__tests__/effector/guard/guardWideNarrow.test.ts

src/types/__tests__/effector/sample/implicitCombine.test.ts

src/types/__tests__/effector/sample/sample.test.ts

src/types/__tests__/effector/sampleFilter/sampleFilterOther.test.ts

This reverts commit 2600985.

@zerobias

Idea by @zerobias

src/types/__tests__/effector/effect.test.ts

src/types/__tests__/effector/fork.test.ts

src/types/__tests__/effector/sampleFilter/sampleFilterWideNarrow.test.ts

src/types/__tests__/effector/store.test.ts

sergeysova and others added 17 commits July 6, 2023 11:42

Introduce EventCallable<T> and StoreWritable<T>

f5229d0

.reinit should be available only on StoreWritable

8c2ee22

use EventCallable for effector-react

700b5e8

use EventCallable for effector-solid

1810b4f

use EventCallable for forest

fccf281

update type snapshot tests for sample

dd63eea

update type snapshot tests for filterSample

af742ed

update type shapshot tests for generated tests of sample

6caa940

fix Target type for sample

297d38f

restore of the shape should produce StoreWritable

6a09cd3

.reset should be only on StoreWritable

13d7770

createApi should return EventCallable

d390fe2

update test snapshots for types

0a67b61

Introduce UnitTargetable as an extension of Unit

72f51cf

Make virtual property less weird

ad64041

Do not require UnitTarget for store.on - any unit should fit

ad079b2

Make ts guard against incompatible store types

f11eee2

AlexandrHoroshih changed the base branch from master to release/v23 September 10, 2023 15:01

AlexandrHoroshih added 4 commits September 10, 2023 22:51

Add type test updates with fixed cases

b3b0f0e

Bump TS to 5.2.2

3fb1a4a

Update type snapshots after ts 5

e5f0102

Update implicit combine snapshots

4257f07

zerobias reviewed Sep 18, 2023

View reviewed changes

src/types/__tests__/effector/generated/sampleFilter.test.ts Show resolved Hide resolved

zerobias reviewed Sep 18, 2023

View reviewed changes

src/types/__tests__/effector/generated/sampleFilter.test.ts Show resolved Hide resolved

zerobias reviewed Sep 18, 2023

View reviewed changes

src/types/__tests__/effector/guard.test.ts Outdated Show resolved Hide resolved

zerobias reviewed Sep 18, 2023

View reviewed changes

src/types/__tests__/effector/guard/guardWideNarrow.test.ts Outdated Show resolved Hide resolved

zerobias reviewed Sep 18, 2023

View reviewed changes

src/types/__tests__/effector/sample/implicitCombine.test.ts Show resolved Hide resolved

zerobias reviewed Sep 18, 2023

View reviewed changes

src/types/__tests__/effector/sample/sample.test.ts Show resolved Hide resolved

zerobias reviewed Sep 18, 2023

View reviewed changes

src/types/__tests__/effector/sampleFilter/sampleFilterOther.test.ts Show resolved Hide resolved

AlexandrHoroshih and others added 7 commits September 18, 2023 19:33

Revert "Delete forward tests with generic usage"

b909c33

This reverts commit 2600985.

Merge branch 'release/v23' into introduce-unit-targetable

98a896e

Merge branch 'release/v23' into introduce-unit-targetable

4abe19e

Update forward types

bf3a848

Idea by @zerobias

Update sample type snapshots after merge

ebf05ab

Fix forward types

77ea3c7

Update snapshots on breaking generic tests

3b867c6