Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover combineEvents method with type tests and fix type safety #93

Merged
merged 2 commits into from
Sep 27, 2020

Conversation

sergeysova
Copy link
Contributor

@sergeysova sergeysova commented Sep 24, 2020

But at now types do not guarantee safety for {target:} property fixed

Relates #22

But at now types do not guarantee safety for {target:} property
@sergeysova sergeysova added enhancement Improvement in existing feature fix PullRequest that fixes something broken tests Add new tests or change type system labels Sep 24, 2020
@sergeysova sergeysova mentioned this pull request Sep 24, 2020
14 tasks
@sergeysova sergeysova removed enhancement Improvement in existing feature tests Add new tests or change type system labels Sep 24, 2020
@sergeysova sergeysova changed the title test(combine-events): cover method with type tests Cover combineEvents method with type tests Sep 24, 2020
@doasync doasync force-pushed the test/combine-events-cover-type-tests branch from ad5eb6b to b227fe6 Compare September 27, 2020 14:49
@sergeysova sergeysova merged commit 3e6e6f2 into main Sep 27, 2020
@sergeysova sergeysova deleted the test/combine-events-cover-type-tests branch September 27, 2020 14:51
@sergeysova sergeysova changed the title Cover combineEvents method with type tests Cover combineEvents method with type tests and fix type safety Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PullRequest that fixes something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants