-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/visitor macro #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
force-pushed
the
refactor/visitor-macro
branch
from
December 18, 2022 11:47
6610ab9
to
c787454
Compare
I think I prefer manually writing recursive functions and then sprinkling-in the recursive macro for boring cases. Like in: enum Exp { case Add(l: Exp, r: Exp); case Sub(l: Exp, r: Exp); case Lit(n: Int) }
export Exp.*
object Optimizations extends Structural {
def dropAddZero(e: Exp): Exp = e match {
case Add(l, Lit(0)) => dropAddZero(l)
case Add(Lit(0), r) => dropAddZero(r)
case e => structuralRewrite(e)
}
}
@main def demo() = println(Optimizations.dropAddZero(Add(Lit(0), Add(Lit(1), Lit(0))))) |
If there are no other voices about this PR, I would go ahead and merge it. You may speak now or forever hold your peace. |
I take this as a "OK" :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start implementing macro to generate tree traversals by simple structural recursion.
@marzipankaiser we talked about this. I am not yet sure the gains are worth the additional complexity. It was fun to implement, though.
Gains:
Problems: