Fix non-zero exit code on error #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiribenes
reviewed
Dec 8, 2023
b-studios
reviewed
Dec 8, 2023
| @@ -121,6 +121,10 @@ class EffektConfig(args: Seq[String]) extends REPLConfig(args) { | |||
|
|
|||
| def interpret(): Boolean = !server() && !compile() && !build() | |||
|
|
|||
| def repl(): Boolean = filenames().isEmpty && !server() && !compile() | |||
|
|
|||
| def exitOnError(): Boolean = !repl() && !server() | |||
There was a problem hiding this comment.
Do we have a semantic name for this? What characterizes these options? Being in batch mode?
|
In our meeting @marzipankaiser mentioned that this might kill |
marzipankaiser
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Tried it locally on my machine.
It seems to do (close enough to) the right thing for me:
- running
effekt ...terminates with useful error code (1 on error) - running
sbt, thenproject effektJVM, thenrun ...does not terminate shell on error, generates compiled output correctly - running
sbt "effektJVM/run ..."terminates with useful error code (1 on error) - running
sbt, theneffektJVM/run ...will terminate the sbt shell on error. While this is somewhat unexpected behaviour, I would not run into this in normal use, so I think this is a good compromise for now.
In Summary: LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #293.
If a message with error severity is logged in compilation/interpret/build mode, effekt now fails with code 1. If run as REPL or server, errors won't cause exits.