Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362 and #365 which surprisingly were the result of the same problem.
effekt/effekt/shared/src/main/scala/effekt/Typer.scala
Lines 1092 to 1097 in e0d28ef
Strangely the given instance provided after
usingCapture
still shadows the previous call.Introduced new combinator
flowingInto
to make scoping more explicit.effekt/effekt/shared/src/main/scala/effekt/Typer.scala
Line 1192 in 69526c2
Now the above code is
effekt/effekt/shared/src/main/scala/effekt/Typer.scala
Lines 1095 to 1103 in 69526c2
which explicitly scopes the implicit
Captures
context.All other changes are clean-up / refactoring changes.
IMO this is a problem with Scala, reproduced here: https://scastie.scala-lang.org/dNPmyHdGSdKJ0atotRofPw