Website breaks to missing extern definitions #374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All examples on the website output
The reason is that recently introduced inlining of extern definitions #350 will inline definitions like
println
effekt/libraries/js/effekt.effekt
Lines 14 to 15 in 5dffce2
which in turn rely on extern includes or literals, such as
effekt/libraries/js/effekt.effekt
Line 8 in 5dffce2
The problem now is that the website uses separate compiling, where the extern includes are only visible to the one module including them. Previously,
println
would simply close over the extern includes. But now, since we inline it, it cannot anymore.Solution implemented in this hotfix
Inlining externs now differs (in JS) between separate and whole program compilation.
Drawback