Refactor Stdlib #449
Refactor Stdlib #449
Conversation
examples/casestudies/anf.effekt.md
Outdated
| @@ -159,8 +159,8 @@ our input: | |||
| ``` | |||
| def pipeline(input: String): String = | |||
| parse(input) { parseExpr() } match { | |||
| case Success(tree) => pretty(translate(tree)) | |||
| case Failure(msg) => msg | |||
| case examples::casestudies::parser::Success(tree) => pretty(translate(tree)) | |||
There was a problem hiding this comment.
Here I'd like to write parser::Success(tree) to disambiguate.
|
Working on the PR I understand @phischu's sentiment to keep the stdlib and prelude small. Almost every test will load the stdlib which is not the point of the test. So maybe we can change the prelude for tests? |
… it will be slow)
This will: - Potentially incur double coercions for arguments - Probably not work in some cases, as we do not track the return type But this does fix the bugs we are currently running into. Note: In the future, a more complete rewrite is needed, as it was written with parametric polymorphism in mind and is now used for subtyping. This means the assumption that casts *only* need to happen at instantiation sites (i.e. call sites) is broken.
| // Context.warning(pp"Extern definition ${id} contains extern string without feature flag. This will likely not work in other backends, " | ||
| // + pp"please annotate it with a feature flag (Supported by the current backend: ${Context.compiler.supportedFeatureFlags.mkString(", ")})") | ||
| // case _ => () | ||
| // } |
There was a problem hiding this comment.
@marzipankaiser I have this commented out here; don't we have your check on master anymore? The diff suggests this
There was a problem hiding this comment.
I'll go ahead and delete this to minify the diff; please complain if we still need this.
|
This is finally ready for review. It would be great if someone could help me make this work on the website again since the paths changed from to just Also, the prelude is much larger (maybe we want to use a smaller prelude on the website?). Can someone check out how long loading and compiling things now takes on the website, given the version in this PR? Maybe @dvdvgt (since you are familiar with the website)? |
Yes, I'll look into it |
|
I'm gonna click merge; please don't build the website with this, yet, until @dvdvgt finished fixing things up. |
This PR uses #427 to refactor the stdlib and share more parts of it.
Issues / annoyances (re)discovered on the way:
importintoincludeandimportand add a project mode!arrays.effektI meant to write