Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Stdlib #449

Merged
merged 54 commits into from
May 24, 2024
Merged

Refactor Stdlib #449

merged 54 commits into from
May 24, 2024

Commits on May 3, 2024

  1. Move parts of js stdlib to common

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5e12cb2 View commit details
    Browse the repository at this point in the history

  2. Allow referring to the module without a prefix

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7cdaf73 View commit details
    Browse the repository at this point in the history

  3. WIP

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d28f1d0 View commit details
    Browse the repository at this point in the history

  4. Share prelude in JS and Chez

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    07e15a1 View commit details
    Browse the repository at this point in the history

  5. Share more of the stdlib

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    fa4232f View commit details
    Browse the repository at this point in the history

  6. Move seq to common

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    96ec6b2 View commit details
    Browse the repository at this point in the history

  7. Also rename usages of put->set

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    928c415 View commit details
    Browse the repository at this point in the history

  8. Add global references to ML

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4f3a78f View commit details
    Browse the repository at this point in the history

  9. Implement more of the string operations in Effekt itself (even though… 

    … it will be slow)
    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b95c1b3 View commit details
    Browse the repository at this point in the history

  10. Allow blocks on with-statements

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1da410c View commit details
    Browse the repository at this point in the history

  11. Favor exceptions over option

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    28b2428 View commit details
    Browse the repository at this point in the history

  12. Disable warnings for now

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a0fc827 View commit details
    Browse the repository at this point in the history

  13. WIP

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    112d2da View commit details
    Browse the repository at this point in the history

  14. Make Chez Scheme tests pass again

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    3d064ff View commit details
    Browse the repository at this point in the history

  15. Start migrating LLVM

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9385a6d View commit details
    Browse the repository at this point in the history

  16. For now inline before (and after) polymorphism boxing to work around … 

    …an issue
    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6c2b7fc View commit details
    Browse the repository at this point in the history

  17. Split tests into those with unicode and those without

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    788a897 View commit details
    Browse the repository at this point in the history

  18. Disable unicode tests in ML

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    bc4ac17 View commit details
    Browse the repository at this point in the history

  19. Fix unicode tests

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7f33200 View commit details
    Browse the repository at this point in the history

  20. Fix type error in LLVM character to int conversion

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    cfc4d1b View commit details
    Browse the repository at this point in the history

  21. Fix WebTests by implementing virtual paths

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    3a78863 View commit details
    Browse the repository at this point in the history

  22. Also escape in lift backend

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    271b139 View commit details
    Browse the repository at this point in the history

  23. Fix ML tests

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2b421f7 View commit details
    Browse the repository at this point in the history

  24. Another occurance of option -> mloption

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c2c4a3f View commit details
    Browse the repository at this point in the history

  25. Fix case study test by helping type inference

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    add2d11 View commit details
    Browse the repository at this point in the history

  26. Merge args (as much as currently possible)

    @b-studios
    b-studios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e005d43 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Create empty matches, not holes

    @b-studios
    b-studios committed May 8, 2024
    Configuration menu
    Copy the full SHA
    373d2a1 View commit details
    Browse the repository at this point in the history

  2. Box characteres

    @b-studios
    b-studios committed May 8, 2024
    Configuration menu
    Copy the full SHA
    244104e View commit details
    Browse the repository at this point in the history

  3. Implement panic in llvm

    @b-studios
    b-studios committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d6837b6 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Add explicit type annotation to Val

    @b-studios
    b-studios committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9ce5ed8 View commit details
    Browse the repository at this point in the history

  2. Use annotated type, that's the whole point of this exercise

    @b-studios
    b-studios committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f925207 View commit details
    Browse the repository at this point in the history

  3. Annotate type in PolymorphismBoxing test 

    IIUC, both 'A and BoxedInt are correct here ('A is bound) but we
do not compare modulo this, apparently.
    @marzipankaiser
    marzipankaiser committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bd5108a View commit details
    Browse the repository at this point in the history

  4. Box/unbox at val-Bindings

    @marzipankaiser
    marzipankaiser committed May 21, 2024
    Configuration menu
    Copy the full SHA
    79b9092 View commit details
    Browse the repository at this point in the history

  5. Add test for unboxing of Nothing in val-Bindings

    @marzipankaiser
    marzipankaiser committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2225bb7 View commit details
    Browse the repository at this point in the history

  6. Make generic show and equals more obscure and fix at least JS tests

    @b-studios
    b-studios committed May 21, 2024
    Configuration menu
    Copy the full SHA
    68a7253 View commit details
    Browse the repository at this point in the history

  7. Fix Chez tests

    @b-studios
    b-studios committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a7248cb View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'master' into refactor/stdlib

    @b-studios
    b-studios committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8d60735 View commit details
    Browse the repository at this point in the history

  2. Fix LLVM tests

    @b-studios
    b-studios committed May 22, 2024
    Configuration menu
    Copy the full SHA
    92109bc View commit details
    Browse the repository at this point in the history

  3. Add explicit type annotation to Let

    @marzipankaiser
    marzipankaiser committed May 22, 2024
    Configuration menu
    Copy the full SHA
    95f209c View commit details
    Browse the repository at this point in the history

  4. Remove old-style Let(x,binding,rest)

    @marzipankaiser
    marzipankaiser committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6b8a1a0 View commit details
    Browse the repository at this point in the history

  5. Box/unbox at let-Bindings

    @marzipankaiser
    marzipankaiser committed May 22, 2024
    Configuration menu
    Copy the full SHA
    bb37766 View commit details
    Browse the repository at this point in the history

  6. Do not insert unnecessary binding on val

    @marzipankaiser
    marzipankaiser committed May 22, 2024
    Configuration menu
    Copy the full SHA
    7e03784 View commit details
    Browse the repository at this point in the history

  7. Add test for unboxing of Nothing in let-Bindings

    @marzipankaiser
    marzipankaiser committed May 22, 2024
    Configuration menu
    Copy the full SHA
    398254b View commit details
    Browse the repository at this point in the history

  8. Use maybeTypeAnnotation

    @marzipankaiser
    marzipankaiser committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f680109 View commit details
    Browse the repository at this point in the history

  9. Fix ML tests

    @b-studios
    b-studios committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f2c48a3 View commit details
    Browse the repository at this point in the history

  10. Fix printing of characters

    @b-studios
    b-studios committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b5fcd6d View commit details
    Browse the repository at this point in the history

  11. Add minimized test case from bug

    @marzipankaiser
    marzipankaiser committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b4d237c View commit details
    Browse the repository at this point in the history

  12. Unbox Nothing by returning a default value

    @marzipankaiser
    marzipankaiser committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8a426d8 View commit details
    Browse the repository at this point in the history

  13. Remove accidentally committed debug-warning

    @marzipankaiser
    marzipankaiser committed May 22, 2024
    Configuration menu
    Copy the full SHA
    cf8c170 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Hotfix: box/unbox function arguments to expected type first 

    This will:
- Potentially incur double coercions for arguments
- Probably not work in some cases, as we do not track the return type

But this does fix the bugs we are currently running into.

Note: In the future, a more complete rewrite is needed, as it was
written with parametric polymorphism in mind and is now used for
subtyping. This means the assumption that casts *only* need to happen
at instantiation sites (i.e. call sites) is broken.
    @marzipankaiser
    marzipankaiser committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2f93303 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/boxing-nothing' into refactor/stdlib

    @b-studios
    b-studios committed May 23, 2024
    Configuration menu
    Copy the full SHA
    75a7945 View commit details
    Browse the repository at this point in the history

  3. Fix Repl tests

    @b-studios
    b-studios committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2af70d9 View commit details
    Browse the repository at this point in the history

  4. Drop generic and monomorphic again as they are not needed anymore

    @b-studios
    b-studios committed May 23, 2024
    Configuration menu
    Copy the full SHA
    67f32bf View commit details
    Browse the repository at this point in the history

  5. Drop commented out code

    @b-studios
    b-studios committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f0fa7e2 View commit details
    Browse the repository at this point in the history