Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generic equals in js backend #499

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Fix generic equals in js backend #499

merged 5 commits into from
Jun 13, 2024

Conversation

marzipankaiser
Copy link
Contributor

@marzipankaiser marzipankaiser commented Jun 13, 2024 •
edited
Loading

Fixes #429.

@marzipankaiser marzipankaiser marked this pull request as ready for review June 13, 2024 10:07
@marzipankaiser marzipankaiser changed the title Fix generic compare in js backend Fix generic equals in js backend Jun 13, 2024
@marzipankaiser marzipankaiser mentioned this pull request Jun 13, 2024
Open
jiribenes
jiribenes approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have one small nitpick for the structure of the hot-fix, but otherwise this is mergeable and improves the current state, thanks! :shipit:

effekt/shared/src/main/scala/effekt/generator/js/Transformer.scala Show resolved Hide resolved
@jiribenes jiribenes merged commit 54d7295 into master Jun 13, 2024
2 checks passed
@jiribenes jiribenes deleted the fix/issue429 branch June 14, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiribenes jiribenes jiribenes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structural equality on JavaScript backend doesn't work
2 participants
@marzipankaiser @jiribenes