Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Add a decimal to binary function #67

Closed
ArupSen opened this issue Jan 27, 2017 · 1 comment
Closed

Add a decimal to binary function #67

ArupSen opened this issue Jan 27, 2017 · 1 comment
Assignees
@ArupSen
Labels
enhancement

Comments

@ArupSen
Copy link
Contributor

ArupSen commented Jan 27, 2017

Hey Kent. I've just started following your course on contributing to projects and I would like to add a decimal to binary function. I've written one for Code Eval and also found this on stack overflow. What do you think?
@kentcdodds
Copy link
Member

Sounds awesome! I look forward to seeing the PR!

ArupSen added a commit to ArupSen/stack-overflow-copy-paste that referenced this issue Jan 29, 2017
@ArupSen
feat(dec2bin): Add a decimal to binary function eggheadio-github#67
5363a68
ArupSen added a commit to ArupSen/stack-overflow-copy-paste that referenced this issue Jan 29, 2017
@ArupSen
feat(dec2bin): Add a decimal to binary function eggheadio-github#67
4a4aef3
kentcdodds pushed a commit that referenced this issue Jan 31, 2017
@ArupSen
feat(dec2bin): Add a decimal to binary function #67
f009f81 
* feat(dec2bin): Add a decimal to binary function #67

* feat(dec2bin): Add decimal to binary function

Closes #69

* Update message for invalid input from String to RangeError

* Update dec2bin to throw RangeError
@ArupSen ArupSen closed this as completed Jan 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ArupSen ArupSen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArupSen @kentcdodds