New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Cannot get coverage quite there #9

Merged
merged 1 commit into from Feb 3, 2016

Conversation

Projects
None yet
3 participants
@kentcdodds
Member

kentcdodds commented Jan 31, 2016

For some reason I was unable to get code coverage to 100% could you please help and provide any other feedback? Thanks!

Here's the coverage report:

screen shot 2016-01-30 at 10 46 46 pm

It looks like I'm just missing coverage for the case where there is no padWith specified. Should I just make a test that covers that case?

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 31, 2016

Current coverage is 100.00%

Merging #9 into master will not affect coverage as of c1b8b3f

@@            master      #9   diff @@
======================================
  Files            3       4     +1
  Stmts           12      16     +4
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             12      16     +4
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of c1b8b3f

Powered by Codecov. Updated on successful CI builds.

codecov-io commented Jan 31, 2016

Current coverage is 100.00%

Merging #9 into master will not affect coverage as of c1b8b3f

@@            master      #9   diff @@
======================================
  Files            3       4     +1
  Stmts           12      16     +4
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             12      16     +4
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of c1b8b3f

Powered by Codecov. Updated on successful CI builds.

*/
function padLeft(str, size, padWith) {
if (size <= str.length) {
return str

This comment has been minimized.

@silvestertomato

silvestertomato Feb 2, 2016

Collaborator

To cover this code, simply add a test that calls padLeft with a size that's smaller than the length of the string you give. For example: padLeft('12345', 3) should do the trick. 👍

@silvestertomato

silvestertomato Feb 2, 2016

Collaborator

To cover this code, simply add a test that calls padLeft with a size that's smaller than the length of the string you give. For example: padLeft('12345', 3) should do the trick. 👍

@silvestertomato

This comment has been minimized.

Show comment
Hide comment
@silvestertomato

silvestertomato Feb 2, 2016

Collaborator

This looks great! Please add that test. Let me know if you need more help! Thanks!

Collaborator

silvestertomato commented Feb 2, 2016

This looks great! Please add that test. Let me know if you need more help! Thanks!

@kentcdodds

This comment has been minimized.

Show comment
Hide comment
@kentcdodds

kentcdodds Feb 2, 2016

Member

I had a little trouble with the commit message, so I ran my commit with --no-verify. Could you help me get that right please? Thanks!

Member

kentcdodds commented Feb 2, 2016

I had a little trouble with the commit message, so I ran my commit with --no-verify. Could you help me get that right please? Thanks!

@silvestertomato

This comment has been minimized.

Show comment
Hide comment
@silvestertomato

silvestertomato Feb 2, 2016

Collaborator

Sure thing! The CONTRIBUTING.md explains our convention a bit. And if you'd like you can add you changes with git add . and then run npm run commit and you'll be given an interactive prompt to use for creating your commit message.

Collaborator

silvestertomato commented Feb 2, 2016

Sure thing! The CONTRIBUTING.md explains our convention a bit. And if you'd like you can add you changes with git add . and then run npm run commit and you'll be given an interactive prompt to use for creating your commit message.

@silvestertomato

This comment has been minimized.

Show comment
Hide comment
@silvestertomato

silvestertomato Feb 2, 2016

Collaborator

It looks like there have been changes in the master branch since you made your changes and there's a merge conflict. Could you kindly rebase your branch with master and resolve any conflicts? Let me know if you need any help doing that!

Collaborator

silvestertomato commented Feb 2, 2016

It looks like there have been changes in the master branch since you made your changes and there's a merge conflict. Could you kindly rebase your branch with master and resolve any conflicts? Let me know if you need any help doing that!

@silvestertomato

This comment has been minimized.

Show comment
Hide comment
@silvestertomato

silvestertomato Feb 2, 2016

Collaborator

Awesome job on the rebase! This is ready to be merged. One more thing though, could you please squash these commits into a single commit with a message that follows our commit message conventions?

Collaborator

silvestertomato commented Feb 2, 2016

Awesome job on the rebase! This is ready to be merged. One more thing though, could you please squash these commits into a single commit with a message that follows our commit message conventions?

@kentcdodds

This comment has been minimized.

Show comment
Hide comment
@kentcdodds

kentcdodds Feb 3, 2016

Member

It's ready to go!

Member

kentcdodds commented Feb 3, 2016

It's ready to go!

@silvestertomato

This comment has been minimized.

Show comment
Hide comment
@silvestertomato

silvestertomato Feb 3, 2016

Collaborator

Fantastic work. This is perfect. I'll merge this pull request and the module will be automatically released using semantic-release (find out how here). Thanks @kentcdodds! 🎊 🎉 :shipit: 🚀

Collaborator

silvestertomato commented Feb 3, 2016

Fantastic work. This is perfect. I'll merge this pull request and the module will be automatically released using semantic-release (find out how here). Thanks @kentcdodds! 🎊 🎉 :shipit: 🚀

silvestertomato added a commit that referenced this pull request Feb 3, 2016

Merge pull request #9 from kentcdodds/pr/padLeft
WIP: Cannot get coverage quite there

@silvestertomato silvestertomato merged commit 65c9793 into eggheadio-github:master Feb 3, 2016

3 checks passed

codecov/patch 100.00% of diff hit (target 100.00%)
Details
codecov/project 100.00% remains the same compared to 3dc204a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment