WIP: Cannot get coverage quite there

[kentcdodds]

For some reason I was unable to get code coverage to 100% could you please help and provide any other feedback? Thanks!

Here's the coverage report:

It looks like I'm just missing coverage for the case where there is no padWith specified. Should I just make a test that covers that case?

[codecov-io]

Current coverage is 100.00%

Merging #9 into master will not affect coverage as of c1b8b3f

@@            master      #9   diff @@
======================================
  Files            3       4     +1
  Stmts           12      16     +4
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             12      16     +4
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of c1b8b3f

Powered by Codecov. Updated on successful CI builds.

[silvestertomato]

To cover this code, simply add a test that calls padLeft with a size that's smaller than the length of the string you give. For example: padLeft('12345', 3) should do the trick. 👍

[silvestertomato]

This looks great! Please add that test. Let me know if you need more help! Thanks!

[kentcdodds]

I had a little trouble with the commit message, so I ran my commit with --no-verify. Could you help me get that right please? Thanks!

[silvestertomato]

Sure thing! The CONTRIBUTING.md explains our convention a bit. And if you'd like you can add you changes with git add . and then run npm run commit and you'll be given an interactive prompt to use for creating your commit message.

[silvestertomato]

It looks like there have been changes in the master branch since you made your changes and there's a merge conflict. Could you kindly rebase your branch with master and resolve any conflicts? Let me know if you need any help doing that!

[silvestertomato]

Awesome job on the rebase! This is ready to be merged. One more thing though, could you please squash these commits into a single commit with a message that follows our commit message conventions?

[kentcdodds]

It's ready to go!

[silvestertomato]

Fantastic work. This is perfect. I'll merge this pull request and the module will be automatically released using semantic-release (find out how here). Thanks @kentcdodds! 🎊 🎉 🚀