Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eggdrop to compile and run under Haiku #637

Merged
merged 13 commits into from
Oct 4, 2018

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Sep 19, 2018

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Fix eggdrop to compile and run under Haiku

Additional description (if needed):

  1. Fix parse error before free_func
    zlib.h must be included after crypto.h
  2. Fix Internal compiler error, output_operand_lossage invalid expression as operand
    Unwitched unnecessary pointer magick
  3. Enable shared build by default for Haiku
  4. Fix checking for a working resolver library
    Add check for -lnetwork
  5. Fix coredns.c:154: field data has incomplete type
    data[] is struct hack (or c99 flexible array member)
    Haiku / gcc 2.95.3 complains but other systems may suffer also, esp. older systems, because the coredns.c struct hack code is "new" in eggdrop.
    This (5) bug is fixed with Fix struct hack / flexible array member #660.
  6. Also update BUG-REPORT and COMPILE-GUIDE for Haiku

Please run misc/runautotools after merge.

Test cases demonstrating functionality (if applicable):

  1. Tested unter Haiku R1 Alpha 4.1:
$ uname -a
Haiku shredder 1 hrevr1alpha4-44702 Nov 14 2012  BePC Haiku
$ gcc --version
2.95.3-haiku-121101
  1. Tested unter Haiku R1 Beta 1:
$ uname -a
Haiku shredder 1 hrev52295+96 Sep 27 2018 18:48: x86_64 x86_64 Haiku
$ gcc --version
gcc version 7.3.0 (2018_05_01)
.status
[...]
OS: Haiku 1
[...]

@@ -301,7 +302,16 @@ Last revised: September 4, 2018
cp /bin/cygz.dll 'C:/eggdrop' (if you selected compress.mod)


I. Tcl Detection and Installation
I. Haiku
If you compile tcl and it breaks with thread error and --disable-threads
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "Tcl" and perhaps a ',' after "help".

@Cizzle Cizzle added this to the v1.8.4 milestone Oct 3, 2018
@michaelortmann
Copy link
Member Author

@Cizzle: done, ready for review again.

@Cizzle
Copy link
Member

Cizzle commented Oct 3, 2018

LGTM

@vanosg vanosg merged commit a8425cb into eggheads:develop Oct 4, 2018
@michaelortmann michaelortmann deleted the haiku branch October 4, 2018 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants