-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eggdrop to compile and run under Haiku #637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pression as operand: unwiched unnecessary pointer magick
…eld data has incomplete type
…beta1 doesnt need it anymore anyway, only alpha1 suffered
Cizzle
reviewed
Oct 3, 2018
doc/COMPILE-GUIDE
Outdated
@@ -301,7 +302,16 @@ Last revised: September 4, 2018 | |||
cp /bin/cygz.dll 'C:/eggdrop' (if you selected compress.mod) | |||
|
|||
|
|||
I. Tcl Detection and Installation | |||
I. Haiku | |||
If you compile tcl and it breaks with thread error and --disable-threads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use "Tcl" and perhaps a ',' after "help".
@Cizzle: done, ready for review again. |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Fix eggdrop to compile and run under Haiku
Additional description (if needed):
zlib.h must be included after crypto.h
Unwitched unnecessary pointer magick
Add check for -lnetwork
data[] is struct hack (or c99 flexible array member)
Haiku / gcc 2.95.3 complains but other systems may suffer also, esp. older systems, because the coredns.c struct hack code is "new" in eggdrop.
This (5) bug is fixed with Fix struct hack / flexible array member #660.
Please run misc/runautotools after merge.
Test cases demonstrating functionality (if applicable):