Fix information leak through TCL variables. #643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: maimizuno
Patch by: michaelortmann
Fixes: #137 and #414 as part of #51
One-line summary:
Fix information leak through TCL variables.
Additional description (if needed):
Before check_tcl_bind() Tcl_SetVar() is called. This Fix adds Tcl_UnsetVar() at the end of check_tcl_bind()
Please don't forget to update (not close) #51 after merge.
Test cases demonstrating functionality (if applicable):
$ ./eggdrop -nt
send private message to eggdrop
before:
after: