fix: dont auto require egg-mock #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fengmk2
commented
Jan 10, 2023
| @@ -270,7 +270,6 @@ describe('test/lib/cmd/test.test.js', () => { | |||
|
|
|||
| // fail on github action ubuntu | |||
| it('test parallel', () => { | |||
| if (process.platform !== 'darwin') return; | |||
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 93 93
Branches 16 16
=========================================
Hits 93 93 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
|
|
|
|
https://github.com/eggjs/egg-mock/blob/master/lib/parallel/app.js#L38 parallel/app.js 没有拿到 env.CLUSTER_PORT 环境变量 |
atian25
pushed a commit
that referenced
this pull request
Jan 11, 2023
[skip ci] ## [5.12.2](v5.12.1...v5.12.2) (2023-01-11) ### Bug Fixes * dont auto require egg-mock ([#206](#206)) ([e703507](e703507)), closes [/github.com/eggjs/egg-mock/pull/142#issuecomment-1377450602](https://github.com/eggjs//github.com/eggjs/egg-mock/pull/142/issues/issuecomment-1377450602)
|
🎉 This PR is included in version 5.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eggjs/egg-mock#142 (comment)
fixed by eggjs/egg-mock#144
Checklist
npm testpassesAffected core subsystem(s)
Description of change