Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl parallel app for mocha parallel mode #130

Merged
merged 1 commit into from Nov 4, 2022
Merged

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Nov 4, 2022

  • use mochaGlobalSetup/mochaGlobalTeardown to setup agent in mocha master process.
  • bootstrap app without agent to aviod port conflict.
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

- use mochaGlobalSetup/mochaGlobalTeardown to setup
agent in mocha master process.
- bootstrap app without agent to aviod port conflict.
@killagu killagu requested a review from fengmk2 November 4, 2022 13:37
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 92.32% // Head: 86.01% // Decreases project coverage by -6.31% ⚠️

Coverage data is based on head (35b0a71) compared to base (fbbd8af).
Patch coverage: 57.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   92.32%   86.01%   -6.32%     
==========================================
  Files          19       23       +4     
  Lines        1915     2295     +380     
  Branches      360      380      +20     
==========================================
+ Hits         1768     1974     +206     
- Misses        147      321     +174     
Impacted Files Coverage Δ
lib/parallel/app.js 30.70% <30.70%> (ø)
lib/parallel/util.js 39.24% <39.24%> (ø)
lib/utils.js 81.57% <63.15%> (-18.43%) ⬇️
lib/parallel/agent.js 85.18% <85.18%> (ø)
bootstrap.js 92.10% <88.88%> (-1.65%) ⬇️
lib/parallel/agent_register.js 100.00% <100.00%> (ø)
lib/request_call_function.js 64.00% <0.00%> (-20.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 merged commit 22f508c into master Nov 4, 2022
@fengmk2 fengmk2 deleted the feat/parallel branch November 4, 2022 14:14
@fengmk2
Copy link
Member

fengmk2 commented Nov 4, 2022

@killagu 你发个版本,重新跑一下 egg-bin 应该就能过了。

@killagu
Copy link
Contributor Author

killagu commented Nov 4, 2022

+ egg-mock@5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants