Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CookieError #31

Merged
merged 2 commits into from
May 2, 2022
Merged

feat: add CookieError #31

merged 2 commits into from
May 2, 2022

Conversation

xuezier
Copy link
Contributor

@xuezier xuezier commented Mar 29, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

no

Description of change

增加 CookieError,使用特殊类型的错误,而不是直接抛出原始的 Error 类,方便后续中间件捕捉实现错误类型判断。

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #31 (452dd64) into master (e2b4c18) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 452dd64 differs from pull request most recent head a6692c8. Consider uploading reports for the commit a6692c8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         4    +1     
  Lines          167       170    +3     
=========================================
+ Hits           167       170    +3     
Impacted Files Coverage Δ
lib/cookies.js 100.00% <100.00%> (ø)
lib/error.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b4c18...a6692c8. Read the comment docs.

@fengmk2 fengmk2 merged commit 7377d3b into eggjs:master May 2, 2022
@fengmk2
Copy link
Member

fengmk2 commented May 2, 2022

2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants