fix(router): support app.get(url, controllerName) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore and @whxaxes to be potential reviewers. |
Current coverage is 99.40% (diff: 100%)
|
atian25
reviewed
Jan 11, 2017
| @@ -1,6 +1,6 @@ | |||
| module.exports = function (app) { | |||
| app.get('/locals/router', app.controller.locals.router); | |||
| app.get('member_index', '/members/index', 'members.index'); | |||
| if (typeof controller !== 'string') return args; | ||
| const actions = controller.split('.'); | ||
| let obj = app.controller; | ||
| actions.forEach(function(key) { |
| /** | ||
| * controller(last argument) support string | ||
| * - [url, controller]: app.get('/home', 'home'); | ||
| * - [name, url, controller]: app.get('home', '/home', 'home'); |
There was a problem hiding this comment.
app.get('home', '/home', 'home'); 前后各一个 home, 要不要换个名字, 如
app.get('newsList', '/news/list', 'news.list'); 这样的? 不过这样也行了.
dead-horse
force-pushed
the
fix-router
branch
from
4a15940
to
4bd5145
Compare
dead-horse
force-pushed
the
fix-router
branch
from
4bd5145
to
4aa93fd
Compare
popomore
reviewed
Jan 12, 2017
| const actions = controller.split('.'); | ||
| let obj = app.controller; | ||
| actions.forEach(key => { | ||
| obj = obj[key]; |
| actions.forEach(key => { | ||
| obj = obj[key]; | ||
| }); | ||
| return Array.prototype.slice.call(args, 0, -1).concat([ obj ]); |
There was a problem hiding this comment.
直接用 args[args.length - 1] = obj 不行吗
| @@ -129,14 +138,10 @@ class Router extends KoaRouter { | |||
| const controller = middleware.pop(); | |||
|
|
|||
| for (const key in REST_MAP) { | |||
| let action = ''; | |||
| if (typeof controller === 'string') { | |||
| action = `${controller}.${key}`; | |||
There was a problem hiding this comment.
兼容的，这段逻辑等于是统一到下面那个方法里面了，进到这里的时候已经都解析成对象了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
closes eggjs/egg#201