feat: plugin support optionalDependencies #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gxcsoccer to be a potential reviewer. |
popomore
changed the title
popomore
force-pushed
the
optionalDependencies
branch
from
3c9d2f8
to
50156c0
Compare
popomore
changed the title
Current coverage is 99.41% (diff: 100%)@@ master #40 diff @@
==========================================
Files 16 16
Lines 669 681 +12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 665 677 +12
Misses 4 4
Partials 0 0
|
atian25
reviewed
Jan 16, 2017
| function depCompatible(plugin) { | ||
| if (plugin.dep && !(Array.isArray(plugin.dependencies) && plugin.dependencies.length)) { | ||
| plugin.dependencies = plugin.dep; | ||
| delete plugin.dep; |
|
不加了吧，文档不要出现就好了
fengmk2 <notifications@github.com>于2017年1月17日 周二00:30写道：
… ***@***.**** commented on this pull request.
------------------------------
In lib/loader/mixin/plugin.js <#40>:
> @@ -355,3 +361,10 @@ module.exports = {
},
};
+
+function depCompatible(plugin) {
+ if (plugin.dep && !(Array.isArray(plugin.dependencies) && plugin.dependencies.length)) {
+ plugin.dependencies = plugin.dep;
+ delete plugin.dep;
需要 depd 提示一下么？
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWA1d8eaOKjAX5prxoB_A-lyMRKEBi5ks5rS5sKgaJpZM4Lkn4P>
.
|
|
1.5.0 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
loadPlugin
Description of change
Closes eggjs/egg#176