Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增interceptTransform 方法的meta参数 #12

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

fengyaogit123
Copy link

@fengyaogit123 fengyaogit123 commented Oct 11, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

popomore and others added 16 commits August 26, 2018 12:27
<!--
Thank you for your pull request. Please review below requirements.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md

感谢您贡献代码。请确认下列 checklist 的完成情况。
Bug 修复和新功能必须包含测试,必要时请附上性能测试。
Contributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md
-->

##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] `npm test` passes
- [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [ ] commit message follows commit guidelines

##### Affected core subsystem(s)
<!-- Provide affected core subsystem(s). -->


##### Description of change
<!-- Provide a description of the change below this comment. -->
transform function can modify and filter logs
which is the original arguments when call log method
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #12 into master will decrease coverage by 66.66%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #12       +/-   ##
===========================================
- Coverage     100%   33.33%   -66.67%     
===========================================
  Files           4        4               
  Lines          48       48               
===========================================
- Hits           48       16       -32     
- Misses          0       32       +32
Impacted Files Coverage Δ
lib/sls_transport.js 42.1% <0%> (-57.9%) ⬇️
lib/sls_logger_client.js 21.05% <0%> (-78.95%) ⬇️
app.js 33.33% <0%> (-66.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592d215...591f94f. Read the comment docs.

@popomore
Copy link
Member

加一个测试用例

@popomore
Copy link
Member

把文档也加上吧

@fengyaogit123
Copy link
Author

把文档也加上吧

image
为什么 本地执行npm run test-local 和cov 都是报错呢

@fengyaogit123
Copy link
Author

把文档也加上吧

image
我发现可能是我没有这些账号所以无法测试
能提供一个可以测试的账号给我吗?
1724238345@qq.com 这是我的邮箱

@popomore
Copy link
Member

为什么 本地执行npm run test-local 和cov 都是报错呢

这个没办法,因为 ci 用的是我的 token

@popomore
Copy link
Member

你可以去阿里云开通一个 sls,设置这几个变量就可以了,测试的流量基本上不要钱。

SLS_ENDPOINT=cn-hangzhou.log.aliyuncs.com
SLS_ACCESS_KEY_ID=
SLS_ACCESS_KEY_SECRET=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants