feat: file path support relative path #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 94.42% 99.45% +5.02%
==========================================
Files 14 14
Lines 377 368 -9
==========================================
+ Hits 356 366 +10
+ Misses 21 2 -19
Continue to review full report at Codecov.
|
|
暂时不需要，这里是在 constructor 里面就 normalize 了 options.file，所以那边读取是没问题的 |
fengmk2
reviewed
Dec 31, 2018
| @@ -15,7 +15,6 @@ module.exports = { | |||
| 'egg-ci', | |||
| ], | |||
| semver: [ | |||
| 'egg-bin@1', | |||
There was a problem hiding this comment.
https://github.com/eggjs/egg-logger/blob/master/package.json#L60
看来一直不支持，应该改一下 engines
fengmk2
approved these changes
Dec 31, 2018
|
2.3.0 |
This was referenced Jan 2, 2019
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change