feat: support customLoader #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atian25
reviewed
Feb 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #3484 +/- ##
==========================================
+ Coverage 99.67% 99.67% +<.01%
==========================================
Files 32 32
Lines 922 923 +1
==========================================
+ Hits 919 920 +1
Misses 3 3
Continue to review full report at Codecov.
|
|
再看看 |
atian25
reviewed
Feb 27, 2019
docs/source/en/advanced/loader.md
Outdated
| // the property name when load to application, E.X. app.controller | ||
| controller: { | ||
| // relative to app.config.baseDir | ||
| directory: 'app/controller', |
There was a problem hiding this comment.
这个是相对代码的，而 logger 不知道会在什么目录
There was a problem hiding this comment.
我想表达的是，logger 那里应该支持配置相对路径，然后我们判断是相对的，自动 join 上 appInfo.root，这样就不会写死了，也不用写 fn 格式的 config 了，简单很多。
而且修改 root 的话，就可以统一修改 custom logger 的所有文件路径了
|
放到 egg-core 吧，Midway 好像是基于 egg-core 的，不是 egg |
4 tasks
4 tasks
atian25
approved these changes
Mar 7, 2019
docs/source/en/advanced/loader.md
Outdated
|
|
||
| ```js | ||
| // app.js | ||
| // This is only the example below, please use 'loadController' instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3480
Checklist
npm testpassesAffected core subsystem(s)
Description of change