Allow all of Sequelize options in config.sequelize
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://docs.sequelizejs.com/en/v3/api/sequelize/#new-sequelizedatabase-usernamenull-passwordnull-options for example: ```js exports.sequelize = { port: '3306', host: 'localhost', username: 'root', password: '', database: 'test', dialect: 'mysql', pool: { max: 5, min: 0, idle: 10000, }, storage: 'db/test-foo.sqlite', timezone: '+08:01', }; ``` Do not assert config.host, password, port config, let them has default value. Do not assert config.database, because SQLite case not need it.
|
@huacnlee, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore, @jtyjty99999 and @luicfer to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 39 35 -4
=====================================
- Hits 39 35 -4
Continue to review full report at Codecov.
|
fengmk2
reviewed
Mar 14, 2017
lib/loader.js
Outdated
| @@ -16,30 +15,18 @@ Sequelize.prototype.log = function() { | |||
| module.exports = app => { | |||
| const config = Object.assign(app.config.sequelize, { | |||
There was a problem hiding this comment.
应该是调转来，app.config.sequelize 去 merge 默认的
fengmk2
approved these changes
Mar 14, 2017
|
我发 patch |
|
@jtyjty99999 我发不了，只能你来发。 |
|
npm owner 加一下我们吧 |
|
修改 Changelog |
|
@huacnlee changelog 在 release 的时候用命令生成的 $ git changelog -n -t 1.1.0
$ vim package.json # change `version`
$ git release 1.1.0
$ npm publish |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://docs.sequelizejs.com/en/v3/api/sequelize/#new-sequelizedatabase-usernamenull-passwordnull-options
Issue from: eggjs/egg#341
for example:
Checklist
npm testpassesAffected core subsystem(s)
Description of change