test: test on travis with node 10 #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popomore
approved these changes
Apr 25, 2018
Codecov Report
@@ Coverage Diff @@
## master #2461 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 29 29
Lines 822 822
=======================================
Hits 819 819
Misses 3 3Continue to review full report at Codecov.
|
dead-horse
commented
Apr 26, 2018
| @@ -24,6 +24,7 @@ describe('test/doc.test.js', () => { | |||
|
|
|||
| it('should no broken url', async () => { | |||
| const result = await findlinks({ src: app.url, logger: console }); | |||
| if (result.fail !== 0) console.log(result); | |||
There was a problem hiding this comment.
@popomore 没有打出具体是哪个 broken 了
There was a problem hiding this comment.
fengmk2
reviewed
Apr 28, 2018
.travis.yml
Outdated
| @@ -3,6 +3,7 @@ language: node_js | |||
| node_js: | |||
| - '8' | |||
| - '9' | |||
|
rebase 一下 |
|
@popomore 有空看看 doctools 的报错吧 |
|
👍 |
popomore
pushed a commit
that referenced
this pull request
Jul 17, 2018
test: test on travis with node 10 (#2461)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change