Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test on travis with node 10 #2461

Merged
merged 7 commits into from Jul 17, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Expand Up @@ -3,6 +3,7 @@ language: node_js
node_js:
- '8'
- '9'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉 9 的

- '10'
install:
- npm i npminstall && npminstall
script:
Expand Down
1 change: 1 addition & 0 deletions appveyor.yml
Expand Up @@ -2,6 +2,7 @@ environment:
matrix:
- nodejs_version: '8'
- nodejs_version: '9'
- nodejs_version: '10'

install:
- ps: Install-Product node $env:nodejs_version
Expand Down
1 change: 1 addition & 0 deletions test/doc.test.js
Expand Up @@ -24,6 +24,7 @@ describe('test/doc.test.js', () => {

it('should no broken url', async () => {
const result = await findlinks({ src: app.url, logger: console });
if (result.fail !== 0) console.log(result);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@popomore 没有打出具体是哪个 broken 了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像有 bug

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

等 doctools 修复了再合并吧

assert(result.fail === 0);
});
});
6 changes: 3 additions & 3 deletions test/lib/core/cookies.test.js
Expand Up @@ -21,7 +21,7 @@ describe('test/lib/core/cookies.test.js', () => {
const ctx = app.mockContext();
assert.throws(() => {
ctx.cookies.set('foo', 'bar', { secure: true });
}, 'Cannot send secure cookie over unencrypted connection');
}, /Cannot send secure cookie over unencrypted connection/);
});

it('should set cookie twice and not set domain when ctx.hostname=localhost', () => {
Expand Down Expand Up @@ -54,7 +54,7 @@ describe('test/lib/core/cookies.test.js', () => {
ctx.cookies.set('foo', 'bar', {
encrypt: true,
});
}, '.keys required for encrypt/sign cookies');
}, /\.keys required for encrypt\/sign cookies/);
});

it('should throw TypeError when get encrypt on keys not exists', () => {
Expand All @@ -65,7 +65,7 @@ describe('test/lib/core/cookies.test.js', () => {
ctx.cookies.get('foo', {
encrypt: true,
});
}, '.keys required for encrypt/sign cookies');
}, /\.keys required for encrypt\/sign cookies/);
});

it('should not set secure when request protocol is http', done => {
Expand Down
4 changes: 2 additions & 2 deletions test/lib/core/loader/load_plugin.test.js
Expand Up @@ -250,7 +250,7 @@ describe('test/lib/core/loader/load_plugin.test.js', () => {
logger,
});
appLoader.loadConfig();
}, 'sequencify plugins has problem, missing: [], recursive: [a,b,c,a]');
}, /sequencify plugins has problem, missing: \[\], recursive: \[a,b,c,a\]/);
});

it('should throw error when plugin dep not exists', function() {
Expand All @@ -262,7 +262,7 @@ describe('test/lib/core/loader/load_plugin.test.js', () => {
logger,
});
appLoader.loadConfig();
}, 'sequencify plugins has problem, missing: [a1], recursive: []\n\t>> Plugin [a1] is disabled or missed, but is required by [c]');
}, /sequencify plugins has problem, missing: \[a1\], recursive: \[\]\s+>> Plugin \[a1\] is disabled or missed, but is required by \[c\]/);
});

it('should auto fill plugin infos', () => {
Expand Down