docs(typescript): optimize docs of typescript #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这些常见问题都是聚焦于 ts 的，所以我直接写到 typescript 这一章里看看有没有问题？ |
atian25
reviewed
Jan 8, 2019
| @@ -416,9 +414,27 @@ declare module 'egg' { | |||
| } | |||
| ``` | |||
|
|
|||
| 在 egg-bin@4.10.0 中，我们还支持通过配置 `egg.require` 来简化 scripts 配置 | |||
|
@atian25 英文版还是让英语好点的同学来改吧 ... 我写的可能会有很多语病 |
Codecov Report
@@ Coverage Diff @@
## master #3374 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 29 29
Lines 844 844
=======================================
Hits 842 842
Misses 2 2Continue to review full report at Codecov.
|
ghost
approved these changes
Jan 11, 2019
|
@atian25 : Please have a check and merge it if possible. |
ghost
merged commit
popomore
pushed a commit
that referenced
this pull request
Jan 12, 2019
docs(typescript): optimize docs of typescript (#3374) Simplify the doc of Typescript
ghost
mentioned this pull request
4 tasks
ghost
pushed a commit
that referenced
this pull request
Jan 13, 2019
Since the TypeScript is changed in doc, this is the sync English version. Ref: #3374
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
更新优化关于 typescript 的使用文档，添加常见问题描述，英语版就等 merged 后 @Maledong 补一下？