Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc (typescript.md): Sync the English translation #3397

Merged
1 commit merged into from Jan 13, 2019
Merged

doc (typescript.md): Sync the English translation #3397

1 commit merged into from Jan 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 12, 2019 •
edited by ghost

Ref: #3374

  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ghost ghost requested review from atian25 and whxaxes January 12, 2019 03:42
@codecov
Copy link

codecov bot commented Jan 12, 2019 •
edited

Codecov Report

Merging #3397 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3397   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          29       29           
  Lines         844      844           
=======================================
  Hits          842      842           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5ef21...810b3ad. Read the comment docs.

atian25
atian25 approved these changes Jan 12, 2019
View reviewed changes
docs/source/en/tutorials/typescript.md Outdated Show resolved Hide resolved
docs/source/en/tutorials/typescript.md Outdated Show resolved Hide resolved
docs/source/en/tutorials/typescript.md Outdated Show resolved Hide resolved
@ghost ghost merged commit cfcebc6 into eggjs:master Jan 13, 2019
@ghost ghost deleted the NewTransForTypeScript branch January 13, 2019 04:48
popomore pushed a commit that referenced this pull request Jan 13, 2019
docs: auto generate by ci
bc8bed5 
doc (typescript.md): Sync the English translation (#3397)

Since the TypeScript is changed in doc, this is the sync English version.
Ref: #3374
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atian25 @whxaxes