Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.29.1 #4498

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Release 2.29.1 #4498

merged 1 commit into from
Oct 20, 2020

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Oct 19, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from killagu October 19, 2020 09:24
@codecov
Copy link

codecov bot commented Oct 19, 2020 •
edited
Loading

Codecov Report

Merging #4498 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #4498   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         1112      1112           
  Branches       183       183           
=========================================
  Hits          1112      1112

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f653af...7a4ab42. Read the comment docs.

killagu
killagu approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atian25 atian25 merged commit 4cfae78 into master Oct 20, 2020
@atian25 atian25 deleted the release-proposal-2.29.1 branch October 20, 2020 03:23
popomore pushed a commit that referenced this pull request Oct 20, 2020
docs: auto generate by ci
bc1f029 
Release 2.29.1 (#4498)
qingdengyue pushed a commit to VioletLife/egg that referenced this pull request Dec 24, 2020
@atian25 @qingdengyue
Release 2.29.1 (eggjs#4498)
e0ac5b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
semver: patch type: release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atian25 @killagu